Menu's can already be easily extended directly it seems?

thadguidry · February 13, 2025, 9:26am

Found this code comment from David when he made the data table view's All menu extensible. There's a loop to call all the extenders.

But is this extensibility only for the All menu directly?
Or is there handling to extend easily for any menu in the DataTableView (thinking to make it even easier for extensions - and what we could do here - perhaps just a few better code comments and docs updated)?

github.com/OpenRefine/OpenRefine

main/webapp/modules/core/scripts/views/data-table/data-table-view.js

28b159d5d


      
            this._collapsedColumnNames = {};
            this._sorting = { criteria: [] };
            this._columnHeaderUIs = [];
            this._shownulls = false;
          
            this._showRows({start: 0});
          }
          
          DataTableView._extenders = [];
          
          /*
            To extend, do something like this
          
            DataTableView.extendMenu(function(dataTableView, menu) {
                ...
              MenuSystem.appendTo(menu, [ "core/view" ], {
                "label": "Test",
                "click": function() {
                    alert("Test");
                } 
              });

github.com/OpenRefine/OpenRefine

main/webapp/modules/core/scripts/views/data-table/data-table-view.js

28b159d5d


      
                    id: "core/display-null",
                    click: function() {
                      $(".data-table-null").toggle();
                      self._shownulls = !(self._shownulls);
                    }
                  }
                ]
              }
            ];
          
            for (var i = 0; i < DataTableView._extenders.length; i++) {
              DataTableView._extenders[i].call(null, this, menu);
            }
          
            MenuSystem.createAndShowStandardMenu(menu, elmt, { width: "120px", horizontal: false });
          };
          
          DataTableView.prototype._createSortingMenu = function(elmt) {
            var self = this;
            var items = [
              {

Topic		Replies	Views
Show OR: My personal UI/UX improvements Development & Design hints-and-tips	6	24	April 14, 2025
Keyboard acceleration extension prototype Development & Design	7	368	February 17, 2023
Customize menu order Support and Helpdesk	3	199	May 17, 2023
Future design projects Development & Design	6	221	March 5, 2024
Column selection UI for applying recipes Development & Design	5	81	February 27, 2025

Menu's can already be easily extended directly it seems?

Related topics