Pull Request (PR) review protocol - feedback requested

As a general rule, I don't specifically request reviews of my PRs unless I think they are particularly suited to a developer's interests or skills, but this practice depends on developers periodically checking the list of open PRs and helping to whittle down the backlog. This allows everyone manage their own time as they see fit, but also means that there's never an explicit prompt to view the backlog.

Would folks prefer that I explicitly ping them when a review is needed?

Another possibility for managing the PR backlog would be to periodically message folks when the backlog exceeds a certain threshold in number or staleness, like Martin has recently done (but with some automation).

For the immediate term, I'll devote time to reviewing/approving/closing PRs which aren't authored by me, but if someone could help out reviewing mine, that would be great.

For Copilot (or other AI generated) PRs, I'd suggest that the developer who did the prompting have the first responsibility for review and that others not be asked to review until they say it's ready. Note that, as we currently have things configured, an approval by the developer who prompted the agent does NOT count towards the approvals needed for merger. We could change this, but I think it's a reasonable policy for now.

Related threads:

1 Like