Releasing 3.9.3

Development & Design
1

It seems we've had a few notable pull requests merged since the release of 3.9.2, so I'd like to propose releasing version 3.9.3 with the following updates:

As I've mentioned elsewhere, I will plan to do the release during an office hour call. If possible, I'll plan to do the release this Thursday, 10 April. Please chime in if you'd like to see other merged pull requests included in the release!

5 Likes
2

Yay! I won't be able to attend the release party but I'm cheering on the sidelines :slight_smile:

1 Like
3

Hi everyone, there were a few issues collecting the planned changes for this release and so 3.9.3 is not going to be available today as originally planned. @antonin_d, would you be available to help talk through the issues we faced?

For context, this is how I approached the release, based on the documentation and observing the release process a few weeks ago:

  1. Check out the 3.9 branch
  2. Cherry-pick the merge commits for the pull requests listed above, as well as any commits they depend on
  3. Try to rebuild the branch, which ultimately revealed that some changes were incomplete and the project would not compile.

Antonin, my impression was that point releases would use cherry-picked merge commits, and minor version releases would pull in everything from the master branch. Does that sound accurate? If so, do you have thoughts on how to resolve the issue of finding the right history to include if merge conflicts arise?

My apologies for the inconvenience of the delayed release. I know these fixes will resolve quite a few headaches, and I am hoping to get these changes released quickly.

2 Likes
4

yes! Although the commits that are cherry-picked aren't "merge" commits, since we normally squash PRs when merging them.

If so, do you have thoughts on how to resolve the issue of finding the right history to include if merge conflicts arise?

In the past, when conflicts arose, I would just solve them myself during this cherry-picking.
If you prefer, you could instead make new PRs for the commits to be cherry-picked, which would be a new occasion to review the changes in their cherry-picked form (hence reviewing your conflict resolution in the same go).

If you need any help with porting any particular commit to the 3.9 release branch, I would be happy to open a PR doing so.

5

Thanks, that's really helpful!

Would you be able to take a look at Fix deserialization of RowAdditionOperation. by wetneb · Pull Request #7247 · OpenRefine/OpenRefine · GitHub ? I had some trouble finding the right set of changes to pull in to make that compatible with the 3.9 branch.

6

Although the commits that are cherry-picked aren't "merge" commits, since we normally squash PRs when merging them.

Ah good point, I'm being a little too informal with my git terminology. I was referring to the single squashed PR commit.

7

Sure! I've made a PR for it at Backport: Fix deserialization of RowAdditionOperation by wetneb · Pull Request #7254 · OpenRefine/OpenRefine · GitHub

1 Like
8

Now that I've had time to look over the issues from last week (and with many thanks to @antonin_d's help) it looks like we're all set to release version 3.9.3 as part of Thursday's office hours call. Thank you for your patience, everyone!

1 Like
9

Hi all, 3.9.3 is now released with the fixes mentioned above. Thanks for the help, @antonin_d and @b2m!

2 Likes